Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): properly detect docker socket path #695

Merged
merged 3 commits into from
Mar 26, 2023
Merged

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Mar 26, 2023

Description

Docker Desktop for Mac no longer places the UNIX socket in the location /var/run/docker.sock for new installations. This prevents Polar from detecting the current version of Docker on the machine. This PR adds detection for the socket file in the new location ~/.docker/run/docker.sock.

I also updated the README with notes on the currently outstanding issues with Docker.

⚠️ Important Docker Notes

  • On Mac & Windows, you must uncheck "Use Docker Compose V2" in Docker Desktop settings. We're waiting on Compose v2 support in the docker-compose NPM package (See PDMLab/docker-compose#228)
  • On Linux, Docker Desktop is currently not supported due to a significant change in how it handles file sharing between host and container (See #636)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (de88044) 100.00% compared to head (609150d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #695   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines         3412      3430   +18     
  Branches       612       616    +4     
=========================================
+ Hits          3412      3430   +18     
Impacted Files Coverage Δ
src/lib/docker/dockerService.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamaljsr jamaljsr merged commit 18125c2 into master Mar 26, 2023
@jamaljsr jamaljsr deleted the fix-docker branch March 26, 2023 13:52
@AlexZeitler
Copy link

Just wanted to let you know we just released v0.24.0 of docker-compose with docker compose plugin support.
Please let us know if you find any issues.

@jamaljsr
Copy link
Owner Author

jamaljsr commented May 1, 2023

@AlexZeitler thanks for the heads up. This is great news! We'll update the package to test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants