Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable condition and bring PHPStan to Level5 #151

Closed
wants to merge 1 commit into from

Conversation

jeromegamez
Copy link
Contributor

I removed the elseif branch because it made the same check and was never reached. I'm not familiar enough with what's happening to know if the second branch was meant to check for something else, though 😅

:octocat:

This brings bunny to PHPStan Level 5
@WyriHaximus
Copy link
Collaborator

Uhm, intend is good. Except that file is generated:

* THIS CLASS IS GENERATED FROM amqp-rabbitmq-0.9.1.json. **DO NOT EDIT!**
using https://github.com/jakubkulhan/bunny/blob/0.6.x/spec/generate.php

@jeromegamez
Copy link
Contributor Author

Shoot, I didn't look into the header! I thought only the Protocol namespace was generated.

Sorry for the waste of time!

@WyriHaximus
Copy link
Collaborator

No worries, loving the work and the energy you put into these PR's 👍 . if you still want to fix it, try and fix it from the generation script. Going to be a lot harder tho 😅

@jeromegamez jeromegamez deleted the phpstan-level-5 branch May 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants