Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rubocop 0.53.0 #31

Closed
wants to merge 3 commits into from

Conversation

amckinnell
Copy link
Contributor

@amckinnell amckinnell commented May 15, 2018

This is a straightforward extension of the current scheme for handling different versions of rubocop: add another configuration file to handle the cop that was renamed as part of the rubocop 0.53.0 release.

This change works just fine for my situation. Looking at the issues and pull requests it most likely will not suit everyone's needs :)

The Style/TrailingCommaInLiteral cop has been replaced by:

  - Style/TrailingCommaInArrayLiteral
  - Style/TrailingCommaInHashLiteral
@olliebennett
Copy link

olliebennett commented Jul 27, 2018

I think this is a good candidate to merge, and a good approach to resolving these compatibility problems long-term.

I think the requirements are;

  • The app "just works", without users needing to override or make decisions about the RuboCop rules they want (especially if they don't use RuboCop in their project already).
  • Maintain a (good) relaxed rubocop dependency in this gem's gemspec, to avoid forcing people to upgrade / downgrade.

Extra nice-to-haves are:

The change (and approach) proposed in this PR meets the two basic requirements above, but not the "nice-to-have"; in future, if/when a broader decision is made about how to configure/override the behaviour of RuboCop, the logic here can be a fallback and default behaviour.

There's related discussion here: #27 and #25

@DamienMetzger
Copy link

👍

@bak1an
Copy link
Collaborator

bak1an commented Mar 5, 2019

Thanks @amckinnell !

Similar change has been merged in #33 so I am closing this.

@bak1an bak1an closed this Mar 5, 2019
@amckinnell amckinnell deleted the support-rubocop-53 branch April 9, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants