-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast-track: Add multipart EntityPart tests #1230
Conversation
4bf5dc1
to
43dcd38
Compare
43dcd38
to
a29adfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the styling in the recently added TCKs in detail, but the general indentation and styling in this PR seems very different to the rest of the codebase. Any chance we can make this more consistent?
@spericas I changed tabs to spaces. Was there other style or formatting issues? Thanks |
Thanks. In general, I think we would prefer this:
over this,
in fluent calls. However, I don't know how consistent we are on this. Maybe we can clean this up and set up some better checkstyle rules after the 4.0 release. |
@jansupol Could you also review this one? |
@spericas Agreed, I will make those changes. Also, I'm working through an issue related to the handling of Headers that will likely result in some additional changes. |
d4338fe
to
d39ab91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and the test passes on RESTEasy with WildFly.
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Outdated
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Outdated
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Outdated
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Outdated
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Show resolved
Hide resolved
jaxrs-tck/src/main/java/ee/jakarta/tck/ws/rs/jaxrs31/ee/multipart/MultipartSupportIT.java
Outdated
Show resolved
Hide resolved
To allow all vendors to run the new test without sacrificing their week schedule, it might be good to remove the "fast-track" marker. In the end, a missing test is not a bug, and I voted -1 for fast-tracking non-bugs. |
From the original Committer Conventions: This is a TCK change and therefore "non-API, non-spec, and non-javadoc" so it can be fast-tracked. All venders would only be required to run with this after it has been placed in a release and we are weeks (or more) away from that. That being said, this PR is generating enough discussion that it is unlikely to be merged in a fast-tracked fashion. |
a0065bf
to
0487108
Compare
0487108
to
600d19b
Compare
In general it LGTM but I'll defer to @jansupol on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixes #962