Update Batch runner for Jakarta EE 11 / JDK 21 / GlassFIsh 8 #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarlow
reviewed
Nov 21, 2024
| @@ -1,87 +1,85 @@ | |||
| CONNECT 'jdbc:derby://localhost:1527/batch;create=true'; | |||
There was a problem hiding this comment.
interesting that you had to add the user/schema app which must mean we are not really logging in as app.
There was a problem hiding this comment.
Even if we are logging in as app though it doesn't hurt to prefix with the user (login) name
scottmarlow
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch runner was not updated for Jakarta EE 11 yet, and when running it would throw errors right away. Updated everything so that it now runs on EE 11 / GlassFIsh 8.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow