Fix CameraBound vs map orientation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the camera-bounded tile provider sets the groundplane as `new Plane(Vector3.up, 0)`, regardless of the actual orientation of the map object. This can be fixed by instead defining the plane by taking three arbitrary points on the map and finding their corresponding point in Unity space, and using these points to define the ground plane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the camera-bounded tile provider sets the groundplane as
new Plane(Vector3.up, 0), regardless of the actual orientation of the map object. This can be fixed by instead defining the plane by taking three arbitrary points on the map and finding their corresponding point in Unity space, and using these points to define the ground plane.Related issue
Example: Closes mapbox#832. Relates to mapbox#832.
Description of changes
Your text here!
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.