Skip to content

Commit

Permalink
Add templates and Checkstyle :wip
Browse files Browse the repository at this point in the history
  • Loading branch information
jaguililla committed Sep 6, 2024
1 parent 1ce9819 commit 091a473
Show file tree
Hide file tree
Showing 5 changed files with 62 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ publish:
- export IMG_REGISTRY="image.registry=${CI_REGISTRY}/jaguililla/hexagonal_spring"
- export POM_VERSION="$(mvn help:evaluate -D expression=project.version -q -D forceStdout)"
- export CI_PUBLISH="spring-boot.build-image.publish=true"
- export MAVEN_ARGS="--quiet --batch-mode --settings .mvn/ci_settings.xml"
- export MAVEN_ARGS="--quiet --batch-mode --settings .gitlab/ci_settings.xml"
- ./mvnw -D ${ALT_REPOSITORY} -D ${IMG_REGISTRY} -D ${CI_PUBLISH} deploy
- rm -rf "${CLIENT_PATH}/src/main/java/${CONTROLLERS_PATH}"
- mvn -f "${CLIENT_PATH}/pom.xml" -D ${ALT_REPOSITORY} clean deploy
Expand Down
File renamed without changes.
25 changes: 25 additions & 0 deletions .gitlab/issue_templates/bug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Bug
about: Software defect.
labels: [ bug ]
---

**REPLACE WITH BUG DETAILS** (Check below for guidelines)

---

Describe the steps and expected results:

```
Given *a condition*
And *another condition*
When *an action is taken*
And *other after the first*
Then *something happened*
And I expected *this other thing*
```

If it is possible, please include:
* The code that produced the error (or a link to it)
* Stack trace of the error and/or logs if available
* Details on the environment the fail happened (i.e.: the OS)
21 changes: 21 additions & 0 deletions .gitlab/issue_templates/enhancement.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
name: Enhancement
about: New feature or improvement.
labels: [ enhancement ]
---

**REPLACE WITH ENHANCEMENT DETAILS** (Check below for guidelines)

---

Detailed description.

Reason for the change or new development.

Acceptance criteria to verify the development. A list of requirements with the following format:

`When *action* then *result*`

For example:

`When this is done then that other thing should happen`
15 changes: 15 additions & 0 deletions .gitlab/merge_request_templates/mr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@

**REPLACE WITH PR DESCRIPTION** (It is also editable after PR creation)

---

For the Pull Request to be accepted please check:

- [ ] The PR has a meaningful title.
- [ ] If the PR refers to an issue, it should be referenced with the GitHub format (*#ID*).
- [ ] The PR is done to the `develop` branch (new features) or the `master` branch (releases).
- [ ] The code pass all PR checks.
- [ ] All public members are documented.
- [ ] The code follow the coding conventions stated at the [contributing.md] file.

[contributing.md]: https://github.com/jaguililla/hexagonal_spring/blob/main/CONTRIBUTING.md

0 comments on commit 091a473

Please sign in to comment.