Implement PSR-3 logging interface #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @estebangarcia , I like the use of echologger, but not everybody is using composer for using this binance api php file. So people that just use the php file in their environment would get an error as they might not have the psr logger. |
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm integrating this library on an HTTP API using Laravel. The "echo" style logging would show up sometimes on the HTTP Responses, breaking the JSON parsing for the clients.
I created a simple PS3 logger that echoes the messages called "EchoLogger" and modified the constructor to be able to override it for anyone that would like to use a different LoggingInterface.