Update supported devices #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was how I got my Launchpad Pro (Mk2) working correctly. Print output: ``` Launchpad Pro 1 -- Not supported ###Midi device Launchpad Pro 2 launchpad_rgb -- Supported ###Midi device Launchpad Pro 3 Launchpad Pro 3 -- Not supported ```
jaggednz
reviewed
Sep 23, 2023
| @@ -32,6 +32,10 @@ local supported_devices = { | |||
| { midi_base_name= 'launchpad pro mk3', device_type='launchpad_rgb' }, | |||
| { midi_base_name= 'launchpad x 2', device_type='launchpad_x' }, | |||
| { midi_base_name= 'launchpad x 2 2', device_type='launchpad_x' }, | |||
| { midi_base_name= 'launchpad Pro 1', device_type='launchpad_rgb' }, | |||
| { midi_base_name= 'launchpad Pro 2', device_type='launchpad_rgb' }, | |||
| { midi_base_name= 'launchpad Pro 3', device_type='launchpad_rgb' }, | |||
There was a problem hiding this comment.
So these devices seem to create 3 USB interfaces, 1. is normally the proprietary interface, 2. is the general midi interface and 3 is something else? In short I think you only need to add 'launchpad pro 2'. Could you please try this modification and confirm if it works?
Thanks and sorry for the very late response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was how I got my Launchpad Pro (Mk2) working correctly. Print output: