Make all caches' store public
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaemk
reviewed
Oct 20, 2021
src/stores/sized.rs
Outdated
| @@ -18,7 +18,7 @@ use {super::CachedAsync, async_trait::async_trait, futures::Future}; | |||
| #[derive(Clone)] | |||
| pub struct SizedCache<K, V> { | |||
| // `store` contains a hash of K -> index of (K, V) tuple in `order` | |||
| pub(super) store: RawTable<usize>, | |||
| pub store: RawTable<usize>, | |||
There was a problem hiding this comment.
I'm not sure if we should really make this one public since modifying it without updating the lru-list would cause some problems. Could we add a method to get a &RawTable<usize> instead?
There was a problem hiding this comment.
- Yes, an immutable reference is probably better.
- I hadn't read
SizedCache's API very carefully; doesn't it make more sense to provide access toorder? - I think it's more consistent to use a function for all.
see updated commit, tell me what you think
For all caches, add a function to get an immutable reference to their contents. This makes it possible to manually dump a cache, so its contents can be saved and restored later.
|
thanks! |
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(was
pub(super)). This makes it possible to manually dump a cache, soits contents can be saved and restored later.
Related to (but does not directly fix) #20.