-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log time settings in CI #6140
Log time settings in CI #6140
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6140 +/- ##
=======================================
Coverage 96.48% 96.49%
=======================================
Files 354 354
Lines 20113 20126 +13
=======================================
+ Hits 19407 19420 +13
Misses 522 522
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@mahadzaryab1 please review |
any idea why the SPM tests are failing? |
Signed-off-by: Yuri Shkuro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Description of the changes
integration.go
whererequire.NoError
was using inside lambda functions passed towaitForCondition
- it was causing tests to fail on transient error with Elastic. Change it to log the error and returnfalse
so thatwaitForCondition
may continue looping & waiting for successful check.