Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log time settings in CI #6140

Merged
merged 8 commits into from
Nov 3, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 29, 2024

Which problem is this PR solving?

  • ES v8.0/v2 integration tests often fail (exampe), but looks like maybe only during certain hours of the day. E.g. yesterday I rerun the workflow 4 times at night and it repeatedly failed, then in the morning it succeeded.

Description of the changes

  • Log time settings in the runner to verify whether it's a time-zone related issue with locating the indices
  • Add debug logging to ES to indicate which indices are being used for reading / writing (did not notice any issues with that in the failed run above)
  • Add debug logging to v2 binary configs
  • Fix a bug in integration.go where require.NoError was using inside lambda functions passed to waitForCondition - it was causing tests to fail on transient error with Elastic. Change it to log the error and return false so that waitForCondition may continue looping & waiting for successful check.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner October 29, 2024 22:05
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (9c1c3ce) to head (622db57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6140   +/-   ##
=======================================
  Coverage   96.48%   96.49%           
=======================================
  Files         354      354           
  Lines       20113    20126   +13     
=======================================
+ Hits        19407    19420   +13     
  Misses        522      522           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.31% <0.00%> (-0.02%) ⬇️
badger_v2 1.67% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 14.39% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2 1.61% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1 14.39% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2 1.61% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.60% <84.21%> (+0.07%) ⬆️
elasticsearch-7.x-v1 18.68% <84.21%> (+0.07%) ⬆️
elasticsearch-8.x-v1 18.85% <84.21%> (+0.07%) ⬆️
elasticsearch-8.x-v2 1.66% <0.00%> (-0.02%) ⬇️
grpc_v1 9.47% <0.00%> (-0.03%) ⬇️
grpc_v2 6.99% <0.00%> (-0.02%) ⬇️
kafka-v1 8.88% <0.00%> (-0.02%) ⬇️
kafka-v2 1.67% <0.00%> (-0.01%) ⬇️
memory_v2 1.67% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 18.73% <84.21%> (+0.08%) ⬆️
opensearch-2.x-v1 18.73% <84.21%> (+0.07%) ⬆️
opensearch-2.x-v2 1.67% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.46% <0.00%> (-0.01%) ⬇️
unittests 95.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro and others added 6 commits October 30, 2024 11:57
@yurishkuro
Copy link
Member Author

@mahadzaryab1 please review

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Nov 3, 2024

any idea why the SPM tests are failing?

Signed-off-by: Yuri Shkuro <[email protected]>
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yurishkuro yurishkuro merged commit 772d84c into jaegertracing:main Nov 3, 2024
50 checks passed
@yurishkuro yurishkuro deleted the Log-time-settings branch November 3, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG storage/elasticsearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants