-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Add HotROD integration test for jaeger-v2 #6138
[jaeger-v2] Add HotROD integration test for jaeger-v2 #6138
Conversation
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6138 +/- ##
==========================================
- Coverage 96.42% 96.39% -0.03%
==========================================
Files 353 353
Lines 20141 20141
==========================================
- Hits 19420 19414 -6
- Misses 534 540 +6
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
v2 test passes now, though i'd one doubt regarding execution which i'll just left in comments |
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
…m/Saumya40-codes/jaeger into hotrod-intergration-test-for-v1v2
Thanks! |
…tracing#6138)" This reverts commit 2d74619.
Which problem is this PR solving?
Description of the changes
Currently in
.github/workflows/ci-docker-hotrod.yml
, we are only testing internally via.scripts/build-hotrod-image.sh
forexamples/hotrod/docker-compose.yml
whileexamples/hotrod/docker-compose-v2.yml
isnt getting coveredFor this, in
.github/workflows/ci-docker-hotrod.yml
we are passing-v
flag to specify the jaeger version (v1
orv2
)How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test