Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector-sampling #6096

Closed
wants to merge 1 commit into from
Closed

Conversation

Garvit-77
Copy link

We appreciate your contribution to the Jaeger project! 👋🎉
-->

Which problem is this PR solving?

Description of the changes

  • Replacing the agent url to the collector url
  • changing the endpoints in agent.go as per the endpoints of collector Http sampling

How was this change tested?

Checklist

@Garvit-77 Garvit-77 requested a review from a team as a code owner October 16, 2024 15:04
@Garvit-77
Copy link
Author

please let me know any changes
@yurishkuro @mahadzaryab1

@inosmeet
Copy link
Contributor

Hey @Garvit-77!
All the commits must be signed in order to pass the DCO check of the GitHub.

@yurishkuro
Copy link
Member

Signed commits is not the concern for me here - the PR itself is meaningless, it just deletes two files. I wouldn't open an issue if the problem was with deleting two files.

@yurishkuro yurishkuro closed this Oct 18, 2024
@Garvit-77
Copy link
Author

I Absolutely get that and to solve the issue Even i wasn't Deleting two files, rather just changed the endpoints for the function
GetSamplingRate to sample the collector .
I will check what went wrong and raise another pr
Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crossdock] Replace sampling calls to agent with calls to collector
3 participants