Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crossdock] Replace sampling calls to agent with calls to collector #6083

Closed
1 of 2 tasks
yurishkuro opened this issue Oct 14, 2024 · 6 comments · Fixed by #6115
Closed
1 of 2 tasks

[crossdock] Replace sampling calls to agent with calls to collector #6083

yurishkuro opened this issue Oct 14, 2024 · 6 comments · Fixed by #6115
Labels
area/sampling enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Oct 14, 2024

Part of #4739 and #6081

In the crossdock integration tests the test driver tries to connect to the "agent" and test its sampling endpoint response. We need to

  • redirect it to query the sampling endpoint in the collector instead
  • remove "agent" related code

cc @mahadzaryab1

@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Oct 14, 2024
@yurishkuro yurishkuro changed the title [crossdock] Replace sampling calls to agent with collector [crossdock] Replace sampling calls to agent with calls to collector Oct 14, 2024
@sriganeshres
Copy link

@yurishkuro i want to work on this issue as it is my first contribution to this repository can you guide me.

@yurishkuro
Copy link
Member Author

@mahadzaryab1 volunteered to guide

@Garvit-77
Copy link

Garvit-77 commented Oct 15, 2024

Hey @yurishkuro
I was looking into this issue but faced some hurdles majorly :
what are Endpoints for OTEL Collector for sampling?

in the ports.go i was able to find that the exposed port == 5778(CollectorV2 sampling http port)

@yurishkuro
Copy link
Member Author

@Garvit-77 Garvit-77 mentioned this issue Oct 16, 2024
2 tasks
@inosmeet
Copy link
Contributor

Do we only need to change the sampling URL endpoint, or should we also refactor the naming? Or am I thinking about this the wrong way?
@yurishkuro @mahadzaryab1

@yurishkuro
Copy link
Member Author

@inosmeet I updated description. Not sure what you mean by "refactor the naming"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sampling enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
4 participants