Clean-up

Signed-off-by: Yuri Shkuro <[email protected]>
jaegertracing · Jul 20, 2024 · f9bf6ba · f9bf6ba
1 parent 3a937b3
commit f9bf6ba
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cmd/jaeger/internal/extension/jaegerquery/server.go b/cmd/jaeger/internal/extension/jaegerquery/server.go
@@ -76,7 +76,6 @@ func (s *server) Start(_ context.Context, host component.Host) error {
 		return err
 	}
 
-	// metricsQueryService, _ := disabled.NewMetricsReader()
 	tm := tenancy.NewManager(&s.config.Tenancy)
 
 	// TODO OTel-collector does not initialize the tracer currently

diff --git a/cmd/jaeger/internal/extension/jaegerstorage/extension.go b/cmd/jaeger/internal/extension/jaegerstorage/extension.go
@@ -137,7 +137,7 @@ func (s *storageExt) Start(_ context.Context, _ component.Host) error {
 	for metricStorageName, cfg := range s.config.MetricBackends {
 		s.telset.Logger.Sugar().Infof("Initializing metrics storage '%s'", metricStorageName)
 		var metricsFactory storage.MetricsFactory
-		var err error = errors.New("empty configuration")
+		var err error
 		if cfg.Prometheus != nil {
 			metricsFactory, err = prometheus.NewFactoryWithConfig(*cfg.Prometheus, s.telset.Logger)
 		}