Skip to content

Commit

Permalink
Add changes
Browse files Browse the repository at this point in the history
Signed-off-by: FlamingSaint <[email protected]>
  • Loading branch information
FlamingSaint committed Jul 24, 2024
1 parent 3ec5360 commit d641e36
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cmd/jaeger/internal/extension/jaegerquery/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (s *server) Start(_ context.Context, host component.Host) error {
}
qs := querysvc.NewQueryService(spanReader, depReader, opts)

mqs, err := s.createMetricStorage(host)
mqs, err := s.createMetricReader(host)
if err != nil {
return err
}
Expand Down Expand Up @@ -128,7 +128,7 @@ func (s *server) addArchiveStorage(opts *querysvc.QueryServiceOptions, host comp
return nil
}

func (s *server) createMetricStorage(host component.Host) (metricsstore.Reader, error) {
func (s *server) createMetricReader(host component.Host) (metricsstore.Reader, error) {
if s.config.MetricStorage == "" {
s.telset.Logger.Info("Metric storage not configured")
return disabled.NewMetricsReader()
Expand Down
2 changes: 1 addition & 1 deletion cmd/jaeger/internal/extension/jaegerquery/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ func TestServerAddMetricsStorage(t *testing.T) {
if tt.extension != nil {
host = storagetest.NewStorageHost().WithExtension(jaegerstorage.ID, tt.extension)
}
_, err := server.createMetricStorage(host)
_, err := server.createMetricReader(host)
if tt.expectedErr == "" {
require.NoError(t, err)
} else {
Expand Down

0 comments on commit d641e36

Please sign in to comment.