Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps from MiniMap.tsx #2615

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

ADI-ROXX
Copy link
Contributor

@ADI-ROXX ADI-ROXX commented Jan 24, 2025

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 24, 2025 04:50
@ADI-ROXX ADI-ROXX requested review from jkowall and removed request for a team January 24, 2025 04:50
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (2d880b4) to head (54cd9c2).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2615   +/-   ##
=======================================
  Coverage   96.61%   96.62%           
=======================================
  Files         255      255           
  Lines        7738     7726   -12     
  Branches     1988     1939   -49     
=======================================
- Hits         7476     7465   -11     
+ Misses        262      261    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: cs-308-2023 <[email protected]>
@ADI-ROXX
Copy link
Contributor Author

Now, the changes are minimized and the default props are also being dealt with.

packages/plexus/src/zoom/MiniMap.tsx Outdated Show resolved Hide resolved
packages/plexus/src/zoom/MiniMap.tsx Outdated Show resolved Hide resolved
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 27, 2025
@yurishkuro yurishkuro enabled auto-merge January 27, 2025 19:29
@yurishkuro yurishkuro added this pull request to the merge queue Jan 27, 2025
Merged via the queue into jaegertracing:main with commit dc642b0 Jan 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants