-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defaultProps from MiniMap.tsx #2615
Merged
Merged
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cs-308-2023 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
=======================================
Coverage 96.61% 96.62%
=======================================
Files 255 255
Lines 7738 7726 -12
Branches 1988 1939 -49
=======================================
- Hits 7476 7465 -11
+ Misses 262 261 -1 ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 25, 2025
Signed-off-by: cs-308-2023 <[email protected]>
Now, the changes are minimized and the default props are also being dealt with. |
yurishkuro
reviewed
Jan 27, 2025
Signed-off-by: cs-308-2023 <[email protected]>
yurishkuro
reviewed
Jan 27, 2025
Signed-off-by: cs-308-2023 <[email protected]>
yurishkuro
approved these changes
Jan 27, 2025
yurishkuro
added
the
changelog:bugfix-or-minor-feature
🐞 Bug fixes, Minor Improvements
label
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test