Skip to content

Commit

Permalink
Remove defaultProps from TraceHeader.jsx (#2620)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #2596 

## Description of the changes
- 

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: cs-308-2023 <[email protected]>
  • Loading branch information
ADI-ROXX authored Jan 25, 2025
1 parent a946fe8 commit 8f5814a
Showing 1 changed file with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,15 @@ export function Attrs(props: AttrsProps) {
);
}

export default function TraceHeader(props: Props) {
const { duration, error, startTime, state, traceID, totalSpans, traceName } = props;
export default function TraceHeader({
duration,
error,
startTime,
state,
traceID,
totalSpans,
traceName,
}: Props) {
const AttrsComponent = state === fetchedState.DONE ? Attrs : EmptyAttrs;

return (
Expand All @@ -101,7 +108,3 @@ export default function TraceHeader(props: Props) {
</div>
);
}

TraceHeader.defaultProps = {
error: undefined,
};

0 comments on commit 8f5814a

Please sign in to comment.