Skip to content

Commit

Permalink
upgrade to using helm3 crd procedure since crd-install hook is no lon…
Browse files Browse the repository at this point in the history
…ger supported

fixes #170

chart.Values.crd.install is no longer support since crd MUST be install
refer: https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds

Signed-off-by: vincentcui <[email protected]>
  • Loading branch information
vincenthcui committed Nov 26, 2020
1 parent 596c29b commit cab19b9
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 14 deletions.
2 changes: 1 addition & 1 deletion charts/jaeger-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: jaeger-operator Helm chart for Kubernetes
name: jaeger-operator
version: 2.17.0
version: 2.18.0
appVersion: 1.19.0
home: https://www.jaegertracing.io/
icon: https://www.jaegertracing.io/img/jaeger-icon-reverse-color.svg
Expand Down
1 change: 0 additions & 1 deletion charts/jaeger-operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ The following table lists the configurable parameters of the jaeger-operator cha
| `image.pullPolicy` | Controller container image pull policy | `IfNotPresent` |
| `jaeger.create` | Jaeger instance will be created | `false` |
| `jaeger.spec` | Jaeger instance specification | `{}` |
| `crd.install` | CustomResourceDefinition will be installed | `true` |
| `rbac.create` | All required roles and rolebindings will be created | `true` |
| `serviceAccount.create` | Service account to use | `true` |
| `rbac.pspEnabled` | Pod security policy for pod will be created and included in rbac role | `false` |
Expand Down
3 changes: 0 additions & 3 deletions charts/jaeger-operator/crds/crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
name: jaegers.jaegertracing.io
annotations:
"helm.sh/hook": crd-install
"helm.sh/hook-delete-policy": "before-hook-creation"
labels:
app: jaeger-operator
spec:
Expand Down
6 changes: 0 additions & 6 deletions charts/jaeger-operator/templates/crds.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions charts/jaeger-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ image:
pullPolicy: IfNotPresent
imagePullSecrets: []

crd:
install: true

jaeger:
# Specifies whether Jaeger instance should be created
create: false
Expand Down

0 comments on commit cab19b9

Please sign in to comment.