Skip to content

Commit

Permalink
Removing playlist sorting - needs a more complete solution
Browse files Browse the repository at this point in the history
  • Loading branch information
jaedb committed Nov 2, 2020
1 parent 9b2a38d commit 1545bcb
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 70 deletions.
2 changes: 1 addition & 1 deletion IRIS_VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.53.0
3.53.1
2 changes: 1 addition & 1 deletion mopidy_iris/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from mopidy import config, ext

__version__ = "3.53.0"
__version__ = "3.53.1"

logger = logging.getLogger(__name__)

Expand Down
42 changes: 4 additions & 38 deletions mopidy_iris/static/app.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion mopidy_iris/static/app.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions mopidy_iris/static/app.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions mopidy_iris/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@

// Release details
// These are automatically injected to built HTML
var build = "1604224903";
var version = "3.53.0";
var build = "1604338606";
var version = "3.53.1";

// Construct the script tag
var js = document.createElement("script");
Expand Down
2 changes: 1 addition & 1 deletion mopidy_iris/static/manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"manifest_version": "3.53.0",
"manifest_version": "3.53.1",
"short_name": "Iris",
"name": "Iris",
"icons": [
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mopidy-iris",
"version": "3.53.0",
"version": "3.53.1",
"description": "Mopidy HTTP interface",
"repository": "https://github.com/jaedb/iris",
"author": "James Barnsley <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = Mopidy-Iris
version = 3.53.0
version = 3.53.1
url = https://github.com/jaedb/iris
author = James Barnsley
author_email = [email protected]
Expand Down
2 changes: 0 additions & 2 deletions src/js/locale/en.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,6 @@ settings:
wide_scrollbars: Use wide scrollbars
grid_glow: Thumbnail glow effect
grid_glow_tooltip: Disable effect for lower-power devices or older browsers
reverse_playlist_tracks: Reverse playlist tracks
reverse_playlist_tracks_tooltip: Sort tracks, most recently-added first
sources_priority:
label: Sources priority
description: Drag-and-drop to prioritize search providers and results
Expand Down
7 changes: 1 addition & 6 deletions src/js/views/Playlist.js
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ class Playlist extends React.Component {
playlist,
loading,
slim_mode,
reverse_playlist_tracks,
} = this.props;

if (!playlist) {
Expand All @@ -295,8 +294,6 @@ class Playlist extends React.Component {
context = 'editable-playlist';
}

const tracks = reverse_playlist_tracks ? sortItems(playlist.tracks, '', true) : playlist.tracks;

return (
<div className="view playlist-view content-wrapper preserve-3d">

Expand Down Expand Up @@ -355,7 +352,7 @@ class Playlist extends React.Component {
uri={playlist.uri}
className="playlist-track-list"
track_context={context}
tracks={tracks}
tracks={playlist.tracks}
removeTracks={this.removeTracks}
reorderTracks={this.reorderTracks}
/>
Expand All @@ -373,7 +370,6 @@ const mapStateToProps = (state, ownProps) => {
allow_reporting,
slim_mode,
theme,
reverse_playlist_tracks,
} = {},
spotify: {
library_playlists: spotify_library_playlists,
Expand Down Expand Up @@ -401,7 +397,6 @@ const mapStateToProps = (state, ownProps) => {
local_library_playlists,
spotify_authorized,
spotify_userid: (me && me.id) || null,
reverse_playlist_tracks,
};
};

Expand Down
14 changes: 0 additions & 14 deletions src/js/views/Settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -387,20 +387,6 @@ class Settings extends React.Component {
</span>
</span>
</label>
<label>
<input
type="checkbox"
name="reverse_playlist_tracks"
checked={ui.reverse_playlist_tracks}
onChange={() => uiActions.set({ reverse_playlist_tracks: !ui.reverse_playlist_tracks })}
/>
<span className="label tooltip">
<I18n path="settings.interface.behavior.reverse_playlist_tracks" />
<span className="tooltip__content">
<I18n path="settings.interface.behavior.reverse_playlist_tracks_tooltip" />
</span>
</span>
</label>
</div>
</div>

Expand Down

0 comments on commit 1545bcb

Please sign in to comment.