This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Small updates for simple-auth >1.0 and latest version(s) of ember #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 20, 2015 18:32
The latest version of simple auth (that supports Ember 2.0) changed its path. Instead of 'simple-auth,' it's now 'ember-simple-auth'. See documentation here: mainmatter/ember-simple-auth#602
In newer versions of ember, the store object is stored as a service. Therefore, calling `store:main` in `container.lookup` will return undefined. Fixed by using `service:store`, but kept `store:main` for backwards compatibility.
* `store.serializerFor` no longer accepts a class (or model) as an argument. Instead, it should be the model name * Initializer no longer passes 'container' to the callback, so removed the param * `secure.userData` is now inside of a `data` object in the latest release of simple auth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library for a project and noticed several issues when upgrading the Ember 2.0 and Simple Auth 1.0 (which is a necessary upgrade to use Ember 2.0). Tried to make the changes so that they do not break for those still on Ember versions lower than 2.0. This change will require a bump to Simple Auth, though, due to a change they made to their file paths (simple-auth -> ember-simple-auth). However, developers can upgrade to the latest version of Simple Auth without being required to upgrade Ember.