Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.7 keyword parameters deprecation warning #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r7kamura
Copy link

This fixes the following warnings that are printed when using this gem with Ruby 2.7.:

/home/ubuntu/foo/vendor/bundle/ruby/2.7.0/gems/acts_as_commentable-4.0.2/lib/commentable_methods.rb:58: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/ubuntu/foo/vendor/bundle/ruby/2.7.0/gems/activerecord-6.0.3.1/lib/active_record/associations.rb:1370: warning: The called method `has_many' is defined here

`has_many` takes keyword-arguments.

> warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
@CloCkWeRX
Copy link

@jackdempsey - would you be ok granting other contributors merge rights; or release rights for this gem? I know for example, fat_free_crm makes use of this and would be happy to take over the maintenance or do an updated/renamed fork.

aschurg added a commit to AdvancedEnergyEconomy/acts_as_commentable that referenced this pull request Jul 28, 2022
code taken from this unmerged pull request: jackdempsey#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants