Add meson build-system support #153
Conversation
[Why] Although the Makefile works perfectly fine as it is right now. It is somewhat dated. Also it makes cross-compiling and packaging a bit tedious. Signed-off-by: Soeren Grunewald <[email protected]>
| @@ -0,0 +1,8 @@ | |||
| libexample_commoncxx = static_library('common', 'scpi-def.cpp', | |||
| include_directories : [ inc, include_directories('.') ], | |||
There was a problem hiding this comment.
Since meson 0.50 (you specified an 0.60 minimum requirement), the arguments to include_directories: [...] can be a string, and it is automatically converted as though the include_directories() function was used. The function is still useful for e.g. defining the inc variable in one directory and using it in another. :)
That being said, implicit_include_directories: true is the default and means that executables/libraries already, implicitly, have '.' as an include directory. So this is redundant.
(You still need it down below for declare_dependency. :))
|
|
||
| inc_private = include_directories( '.' ) | ||
|
|
||
| libscpi = both_libraries('scpi', |
There was a problem hiding this comment.
Instead of both_libraries, I would generally recommend using library() but setting the meson project option default_options: ['default_library=both'].
This allows end users to decide which ones they need, if they really want to. Unless there's a technical reason why the software requires that all users have both of them.
| test('fifo', | ||
| executable('fifo', 'test_fifo.c', dependencies: deps) | ||
| ) | ||
|
|
||
| test('lexer_parser', | ||
| executable('lexer_parser', 'test_lexer_parser.c', dependencies: deps) | ||
| ) | ||
|
|
||
| test('parser', | ||
| executable('parser', 'test_parser.c', dependencies: deps) | ||
| ) | ||
|
|
||
| test('scpi_utils', | ||
| executable('scpi_utils', 'test_scpi_utils.c', dependencies: deps) | ||
| ) | ||
| endif |
There was a problem hiding this comment.
You could probably do all this with a foreach loop, too.
|
|
||
| cc = meson.get_compiler('c') | ||
|
|
||
| install_data(files(['LICENSE', 'README.md'])) |
There was a problem hiding this comment.
The current Makefile doesn't install README.md anywhere... I wonder how generally useful this is?
The LICENSE file, since meson 1.1.0, can be handled via https://mesonbuild.com/Reference-manual_functions.html#project_license_files
Although the Makefile works perfectly fine as it is right now, it is somewhat dated. Also it makes cross-compiling and packaging a bit tedious.
So this will allow to build the library and some of the examples with meson.