Update libraries and remove deprecations #818 #819
Conversation
composer.json
Outdated
| "symfony/browser-kit": "5.3.*", | ||
| "symfony/css-selector": "5.3.*", | ||
| "symfony/debug-bundle": "5.3.*", | ||
| "phpunit/phpunit": "^9.5", |
There was a problem hiding this comment.
Is it required? Because we use simple-phpunit to run test and not phpunit directly
|
I prefer the latest phpunit, as Symfony no longer appears to mention
simple-phpunit in it's documentation:
https://symfony.com/doc/current/testing.html#the-phpunit-testing-framework
But honestly I don't know, both work, I think simple-phpunit is now at 8.5,
while phpunit is at 9.5.
I can remove it, though, until there's a better reason to switch.
…On Mon, Nov 15, 2021 at 4:01 AM Jérémy Benoist ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In composer.json
<#819 (comment)>:
> @@ -65,13 +65,14 @@
"phpstan/phpstan-doctrine": "^0.12",
"phpstan/phpstan-phpunit": "^0.12",
"phpstan/phpstan-symfony": "^0.12",
- "symfony/browser-kit": "5.3.*",
- "symfony/css-selector": "5.3.*",
- "symfony/debug-bundle": "5.3.*",
+ "phpunit/phpunit": "^9.5",
Is it required? Because we use simple-phpunit to run test and not phpunit
directly
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#819 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQIN3VBYRGCKSZOMCELUMDD43ANCNFSM5H74FGJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hmm, I removed it, and now I can't seem to get the tests to run locally,
even after following
composer require --dev symfony/phpunit-bridge
C
Can you tweak this PR please?
…On Mon, Nov 15, 2021 at 7:37 AM Tac Tacelosky ***@***.***> wrote:
I prefer the latest phpunit, as Symfony no longer appears to mention
simple-phpunit in it's documentation:
https://symfony.com/doc/current/testing.html#the-phpunit-testing-framework
But honestly I don't know, both work, I think simple-phpunit is now at
8.5, while phpunit is at 9.5.
I can remove it, though, until there's a better reason to switch.
On Mon, Nov 15, 2021 at 4:01 AM Jérémy Benoist ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In composer.json
> <#819 (comment)>:
>
> > @@ -65,13 +65,14 @@
> "phpstan/phpstan-doctrine": "^0.12",
> "phpstan/phpstan-phpunit": "^0.12",
> "phpstan/phpstan-symfony": "^0.12",
> - "symfony/browser-kit": "5.3.*",
> - "symfony/css-selector": "5.3.*",
> - "symfony/debug-bundle": "5.3.*",
> + "phpunit/phpunit": "^9.5",
>
> Is it required? Because we use simple-phpunit to run test and not
> phpunit directly
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#819 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAEXIQIN3VBYRGCKSZOMCELUMDD43ANCNFSM5H74FGJA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
I'll check when I got some spare time |
|
What do you think about bumping to the latest Symfony/PHP? This is a cool project, since it's not a library or bundle, there's little downside in tagging a new version and upgrading. |
|
I'm still running PHP 7.4 for some other pet projects and that's mostly the reason I didn't upgrade the Symfony version. |
|
I've been doing a lot of upgrading of projects to PHP8 (rector rocks for that), I might be able to lend a hand. The biggest issue I've faced when upgrading projects from Symfony 4 and 5 is moving to the new security system. Second biggest is framework related (new index.php and bin/console). Neither are too bad. I just tried to merge your latest changes, and indeed that's where I had conflicts. I'll see if I can get my branch working, I had an issue wiith MySQL not installing, but I'm on a new computer now and it's going better. |
|
OK, I think my fork now works handing both situations. If php 7.4, it installs Symfony 5.4, and if PHP 8, it install the Symfony 6.1 components. While it's working for me locally, I'm not sure I migrated security.yaml correctly. PHP 7.4 will stop receiving security fixes in 2 months... |
Prepare for Symfony 6 by removing deprecations.