battle notes

j-mie6 · Aug 11, 2023 · 8df33c8 · 8df33c8
1 parent b6a988f
commit 8df33c8
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/parsley/shared/src/main/scala/parsley/character.scala b/parsley/shared/src/main/scala/parsley/character.scala
@@ -405,6 +405,7 @@ object character {
     }
 
     // TODO: document
+    // TODO: optimise, this can be _really_ tightly implemented with a substring on the input
     def stringOfMany(pred: Char => Boolean): Parsley[String] = stringOfMany(satisfy(pred))
 
     // TODO: document that it only handles 16-bit characters
@@ -436,6 +437,7 @@ object character {
     }
 
     // TODO: document
+    // TODO: optimise, this can be _really_ tightly implemented with a substring on the input
     def stringOfSome(pred: Char => Boolean): Parsley[String] = stringOfSome(satisfy(pred))
 
     /** This combinator tries to parse each of the strings `strs` (and `str0`), until one of them succeeds.