WIP: Fix deadlock happens if a big file is uploaded #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mie00
changed the title
mie00
force-pushed
the
patch-1
branch
5 times, most recently
from
ba62e24 to
58642a8
Compare
in the write stream, the stream uncork happens before the actual write method ends, and so the data doesn't get written completely. When this happen, the drain event doesn't get fired and so who ever writes to the stream waits indefnitely for the drain event. The fix was to move the uncork, cork calls to the callback of the stream.write method
|
This pr is underrated. Proper drain event is very important when dealing with write streams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the write stream, the stream uncork happens before the actual write method ends, and so the data doesn't get written completely. When this happen, the drain event doesn't get fired and so who ever writes to the stream waits indefnitely for the drain event.
The fix was to move the uncork, cork calls to the callback of the stream.write method