-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JM's suggested tweaks based on rfds upgrade #26
base: master
Are you sure you want to change the base?
Commits on Jul 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for af6eded - Browse repository at this point
Copy the full SHA af6ededView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a95dd - Browse repository at this point
Copy the full SHA 85a95ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6a135e - Browse repository at this point
Copy the full SHA d6a135eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d35c58 - Browse repository at this point
Copy the full SHA 7d35c58View commit details -
Configuration menu - View commit details
-
Copy full SHA for f165ecf - Browse repository at this point
Copy the full SHA f165ecfView commit details
Commits on Jul 7, 2020
-
Codefresh pushes untested Docker image to make it cacheable
Push the built but pre-test Docker image in parallel with the tests run so that the image will be available for fetching from Docker Hub if necessary, e.g. if you re-run the Codefresh run, or want to fetch and debug a failing image locally. This is mainly motivated by the fact that Codefresh no longer provides its own repository for images, which it used to, and thus no longer caches every built image including those that failed the `run_tests` step.
Configuration menu - View commit details
-
Copy full SHA for dfcffbe - Browse repository at this point
Copy the full SHA dfcffbeView commit details -
Add recommended lib version constraints for Django 1.8
These are the constraints for ixc-django-docker's dependencies that worked for the RFDS site that uses Django 1.8, when re-creating that project's pinned requirements.txt file from scratch.
Configuration menu - View commit details
-
Copy full SHA for a39a5c4 - Browse repository at this point
Copy the full SHA a39a5c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee6689 - Browse repository at this point
Copy the full SHA 7ee6689View commit details -
Make DOTENV available as a default setting
DOTENV is useful in many places, such as setting unique names for things like databases or ElasticSearch indexes etc. Make it easily available as a setting that is guaranteed to be present, and given a clear default value if not, instead of requiring projects to hunt for and handle the 'DOTENV' environment variable.
Configuration menu - View commit details
-
Copy full SHA for b2444e3 - Browse repository at this point
Copy the full SHA b2444e3View commit details
Commits on Jul 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 37bc343 - Browse repository at this point
Copy the full SHA 37bc343View commit details -
Merge branch 'master' into jm-suggested-tweaks-based-on-rfds-upgrade
* master: Do not match pyenv error string accidentally, which says the required version is NOT installed. Fix flipped bool test. Actually exit when dependencies are not met. Don't specify base image version in comments. Remove extra blank line. Export `CPATH` so zlib headers can be found from Xcode while building wheels in Catalina.
Configuration menu - View commit details
-
Copy full SHA for 6f26d0c - Browse repository at this point
Copy the full SHA 6f26d0cView commit details -
Remove ref to project-specific admin_tools from default URLs
The `admin_tools` app comes from django-admin-tools which isn't referenced anywhere else in ixc-django-docker, so this was probably added to the default URLs by mistake.
Configuration menu - View commit details
-
Copy full SHA for 3876fdd - Browse repository at this point
Copy the full SHA 3876fddView commit details -
Add setting ADMIN_URL to customise location of site admin
For RFDS the site admin is under /rfds-admin/ not /admin/. The new ADMIN_URL setting makes the admin URL prefix easily configurable in downstream projects without needing to mess with URL patterns.
Configuration menu - View commit details
-
Copy full SHA for 36698c2 - Browse repository at this point
Copy the full SHA 36698c2View commit details -
Merge branch 'master' into jm-suggested-tweaks-based-on-rfds-upgrade
* master: Add missing `revision` to main clone step.
Configuration menu - View commit details
-
Copy full SHA for 541e50f - Browse repository at this point
Copy the full SHA 541e50fView commit details
Commits on Jul 13, 2020
-
Remove redundant
npm run build
stepThis step is redundant in setup.sh because it gets run as part of the recommended Dockerfile when building an image. Before this change static files etc would get generated by the Codefresh build, then again slowly and pointlessly when you run the setup service. So either this command should be removed altogether from this script, or maybe be adjusted to run only in a local development context?
Configuration menu - View commit details
-
Copy full SHA for 3812b4e - Browse repository at this point
Copy the full SHA 3812b4eView commit details