Vertex id #13
Merged
Vertex id #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, "triangulating" a triangle results in two copies of itself.
This enables the library user to map the output vertices in the final triangulation/partition back to the input vertices. This allows additional vertex attributes to be mapped from the input vertices onto the output triangle vertices in a straightforward way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a user-defined vertex id as a simple way to address issue #8.
This enables the user to map the output vertices in the final triangles/partition back to the input vertices. This allows additional vertex attributes to be mapped from the input vertices onto the output triangles in a straightforward way. Choice of an integer vertex id to represent vertex properties may not be the most convenient in all cases. A more complex alternative would be template TPPLPoint on the type of
id, but then you'd need to pull most of the implementation into the header which seems like quite an unfortunate tradeoff.Also included in a separate commit is a couple of whitespace changes to make indentation more consistent. The
Triangulate_MONOpatch (pr #12) has also unfortunately infected this PR due to me sloppily making #12 off my master branch.