Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose mutable reference to real part of a dual number #87

Closed
wants to merge 1 commit into from
Closed

Expose mutable reference to real part of a dual number #87

wants to merge 1 commit into from

Conversation

RagibHasin
Copy link
Contributor

It is useful when normalizing periodic variables (i.e. angles).

@prehner
Copy link
Contributor

prehner commented Nov 24, 2024

Not sure I like that. You're use case is one of the special cases where that would be interesting but you already have SubAssign<f64> which would serve the same purpose. On the other hand just mutating the real part without making sure that the derivatives are still correct can lead to unexpected errors.

@RagibHasin
Copy link
Contributor Author

Oh, I didn't think about using SubAssign at all! I think it should be closed then.

@RagibHasin RagibHasin closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RagibHasin @prehner