refactor(layouts): Category pages (excl. videos.html) use common layout file #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_layouts/default_category.html created to store common code. All category/ files except videos.html use default_category for layout.
|
@jcarstairs-scottlogic - please let me know when you have your changes merged into the mainsite and I'll rebase with an updated layouts file so that I can test a deployed version on ithake/blog-slogic before submitting to the main site. |
There was a problem hiding this comment.
Looks good: but you'll want to merge into ScottLogic/gh-pages, not the gh-pages branch on your repo, and assuming the landmark roles PR gets merged first, you'll want to include <main> in the default category layout. I'll notify you when that gets merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_layouts/default_category.html created to store common code.
All category/ files except videos.html use default_category for layout.
Affected category pages:
Unaffected category page:
(excluded as the logic is slightly different).
Testing
Visually checked each category file lined up with current blog:
Checklist
Have you (please tick each box to show completion):
Posts are approved based on their category. replace
(at)with@to notify them!