Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename manifest.json to manifest.webmanifest #368

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

andy128k
Copy link
Collaborator

It seems .webmanifest is a preferable extension these days.
It was reported in #280 and jantimon/favicons-webpack-plugin#272

@andy128k andy128k added this to the 7.0.0 milestone Nov 13, 2021
@alexander-akait
Copy link
Member

NOTE: File extension: .webmanifest or .json?
The IANA registered file extension for the manifest is .webmanifest. Some web servers recognize this extension and transfer the file using the standardized application manifest media type (application/manifest+json). Developers can also choose a different extension (e.g. .json) or none at all (e.g. /api/GetManifest), but are encouraged to transfer the manifest using the application/manifest+json MIME type, although any JSON MIME type is ok.

https://w3c.github.io/manifest/

Looks any extension is valid, but I am fine with this change

@andy128k
Copy link
Collaborator Author

While any extension is acceptable, it seems .webmanifest has some pros. OTOH it is still possible to change the name by passing a parameter manifestFileName.

@alexander-akait
Copy link
Member

Yep, feel free to merge

@andy128k andy128k merged commit 968ec9b into master Nov 16, 2021
@andy128k andy128k deleted the webmanifest branch November 16, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants