POC: itgalaxy/favicons#221 use sharp instead of phantomjs

[kghost]

No description provided.

[alexander-akait]

Awesome, sharp is good choice

[alexander-akait]

/cc @brunocodutra

[kghost]

There are still issues about how sharp stretch images, I'll try fix it soon

[alexander-akait]

@kghost also need fix CI

[kghost]

All commit tested.

1. https://travis-ci.org/kghost/favicons/builds/471366944 Pass
2. https://travis-ci.org/kghost/favicons/builds/471367724 Fail,
   Snapshots are generated by sharp. Resemble has problem comparing small pictures, favicon-16x16.png difference (misMatchPercentage) is 13%, above the threshold 5%. Also prove that image compare actually works.
3. https://travis-ci.org/kghost/favicons/builds/471384328 Pass

[brunocodutra]

Do you think we can use the new image comparator for all unit tests in place of AVA's snapshot?

[kghost]

This pr already takes too long, I suggest merge it and improve it later.

[brunocodutra]

@kghost I raised a question above - is there any reason why the new image comparator was not used for all unit tests?

Either all tests should use AVA snapshots or they should all use the image comparator, but having both methods coexist would make it harder to maintain this library.

[pniederlag]

Since a recent update on my devbox(debian) phantomjs seems completly broken.

I extracted the main patch to switch from svg2png to sharp and rebased it to master. https://github.com/pniederlag/favicons/tree/pr/254-part1

Good News: this way I can generate the favicons again.

It would be really cool to get this Fix shipped and packaged. Big thx for putting your efforts into this!

[alexander-akait]

Can we rebase?

[kghost]

Coming back from spring vacation, I'll fix the remaining problem next week.

[alexander-akait]

Also please rebase 👍

[kghost]

ping @brunocodutra

[RomanHotsiy]

@brunocodutra do you plan to cut a new release anytime soon?
Thanks!

[brunocodutra]

I was hoping to address #253 before releasing, but if there's demand for a release meanwhile I can cut one.

[RomanHotsiy]

Ah, great. No need to hurry. Thanks for the update!