Skip to content

Commit

Permalink
Thought about output level.
Browse files Browse the repository at this point in the history
All messages on StdErr should end up in logger
That is Message
Error: Message
    (Additional Information: B)
Should end up as Error Level: "Message", Warning Level: "    (Additional Information: B)"
NoWarn hides messages completely in IkvmImporterInternal.IssueMessage
  • Loading branch information
AliveDevil committed Aug 19, 2024
1 parent e86b482 commit 290034d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/IKVM.Tools.Runner/Importer/IkvmImporterLauncher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ public async Task<int> ExecuteAsync(IkvmImporterOptions options, CancellationTok
await LogEvent(IkvmToolDiagnosticEventLevel.Debug, "Executing {0} {1}", cli.TargetFilePath, cli.Arguments);

// send output to MSBuild
cli = cli.WithStandardErrorPipe(PipeTarget.ToDelegate(i => LogEvent(IkvmToolDiagnosticEventLevel.Information, i)));
cli = cli.WithStandardErrorPipe(PipeTarget.ToDelegate(i => LogEvent(IkvmToolDiagnosticEventLevel.Warning, i)));
cli = cli.WithStandardOutputPipe(PipeTarget.ToDelegate(i => LogEvent(IkvmToolDiagnosticEventLevel.Debug, i)));

// combine manual cancellation with timeout
Expand Down

0 comments on commit 290034d

Please sign in to comment.