Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sftptogo to protocols/index #350

Merged
merged 1 commit into from
Mar 28, 2023
Merged

added sftptogo to protocols/index #350

merged 1 commit into from
Mar 28, 2023

Conversation

saggineumann
Copy link

Somehow missed this in yesterday's PR 🤦

@AliveDevil
Copy link
Contributor

We could just pay more attention to the build logs 🙃

https://github.com/iterate-ch/docs/pull/346/checks#step:4:236

@dkocher dkocher self-requested a review March 22, 2023 12:22
dkocher
dkocher requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a Providers section to the SFTP page instead as in WebDAV.

protocols/index.md Outdated Show resolved Hide resolved
protocols/index.md Outdated Show resolved Hide resolved
protocols/index.md Outdated Show resolved Hide resolved
@saggineumann
Copy link
Author

@dkocher no problem - I followed files.com's as an example. Shall I go ahead and add the providers section to the SFTP page? Should I move anything besides SFTP To Go in there?

@saggineumann
Copy link
Author

@dkocher also note that SFTP, FTPS and S3 are all protocols that work with SFTP To Go - should I add providers to these pages too?

@dkocher
Copy link
Contributor

dkocher commented Mar 22, 2023

@dkocher also note that SFTP, FTPS and S3 are all protocols that work with SFTP To Go - should I add providers to these pages too?

We may want to restructure this later.

@saggineumann
Copy link
Author

@dkocher care to review again please?

@dkocher
Copy link
Contributor

dkocher commented Mar 24, 2023

Looks good to me. Would you mind squashing the two commits.

added sftptogo to protocols/index
abf04aa 
moved sftptogo under sftp with provider links from s3 and ftp
@saggineumann
Copy link
Author

squashed

@dkocher dkocher self-requested a review March 26, 2023 13:49
@saggineumann
Copy link
Author

@dkocher is there anything else required from my end in order to deploy & close PR?

@dkocher dkocher merged commit 391104c into iterate-ch:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saggineumann @AliveDevil @dkocher