Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring/18app #916

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Refactoring/18app #916

wants to merge 8 commits into from

Conversation

astagi
Copy link
Member

@astagi astagi commented Feb 19, 2021 •
edited
Loading

Description

This PR refactors 18app

Checklist

  • I followed the indications in CONTRIBUTING.md
  • The documentation related to the proposed change has been updated accordingly (also comments in code).
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Ready for review! 🚀

@vercel
Copy link

vercel bot commented Feb 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/developers-italia-it/oSFFP6hyRKLtbmLB2zLWvhZUuzQm
✅ Preview: https://developers-ita-git-refactoring-18app-dip-trasformazione-19ad44.vercel.app

@astagi astagi self-assigned this Feb 19, 2021
@astagi astagi marked this pull request as ready for review March 10, 2021 07:28
@astagi astagi requested a review from libremente March 10, 2021 07:28
libremente
libremente reviewed Mar 17, 2021
View reviewed changes
_platforms/it/18app.md Outdated
dotato di un certificato di autenticazione da installare nel proprio client del
servizio e da utilizzare nella chiamata SOAP per effettuare l’autenticazione in
modalità SSL con certificato client. Per maggiori informazioni consulatre la
[sezione dedicata nella Guida per gli esercenti](https://docs.italia.it/italia/18app/18app-esercenti-docs/it/bozza/linee-guida-esercenti.html#allegato-1-specifica-ws-online).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, due to this that page looks a bit weird.
I would not link to Docs Italia documentation since it has never been recognized to be the official one. Can you look for the official documentation? Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the official doc is on the main website

_platforms/it/18app.md Outdated
@@ -73,7 +79,7 @@ Questi spazi di discussione non sono presidiati da Sogei pertanto non sono canal

## App nativa

In Developers Italia è in corso lo sviluppo di una app nativa per 18app, che nella primavera 2019 diventerà la app ufficiale.
In Developers Italia è in corso lo sviluppo di una app nativa per 18app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, it's not "under development" anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@libremente should we delete this section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@astagi astagi marked this pull request as draft April 16, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libremente libremente libremente left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@astagi astagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astagi @libremente