Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

912 feature numeric input component #982

Merged
merged 45 commits into from
Dec 12, 2023

Conversation

sabato-galasso
Copy link
Collaborator

Fixes #912

PR Checklist

  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

  • Updated docs and new type number input

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Dec 12, 2023 2:44pm

@astagi astagi changed the base branch from next to main December 11, 2023 08:43
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (adbd34f) 95.42% compared to head (590d9bd) 94.77%.

Files Patch % Lines
src/Input/Input.tsx 47.36% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   95.42%   94.77%   -0.65%     
==========================================
  Files         283      283              
  Lines        2775     2813      +38     
  Branches      696      715      +19     
==========================================
+ Hits         2648     2666      +18     
- Misses        125      145      +20     
  Partials        2        2              
Flag Coverage Δ
unittests 94.77% <51.21%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit d4a299c into italia:main Dec 12, 2023
5 of 6 checks passed
@sabato-galasso sabato-galasso deleted the 912-feature-numeric-input-component branch December 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Numeric Input component
2 participants