feat: rework Select to use reactstrap implementation

[federico-ntr]

Fixes #914

PR Checklist

• My branch is up-to-date with the Upstream master branch.
• The unit tests pass locally with my changes (if applicable).
• I have added tests that prove my fix is effective or that my feature works (if applicable).
• I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
design-react-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 4, 2023 9:16am

[dej611]

Code review pass

[dej611]

This should extends the native HTML select element props, similar to the Input component:

design-react-kit/src/Input/Input.tsx

Line 50 in 23bed3f

export interface InputProps extends InputHTMLAttributes<HTMLInputElement> {

Something like:

Suggested change

	export interface SelectProps {
	export interface SelectProps extends HTMLSelectAttributes<HTMLSelectElement> {

[dej611]

Not required if extending the native element

[dej611]

Suggested change

	handleChange: (selectedValue: string) => void;
	onChange: (selectedValue: string) => void;

[federico-ntr]

The problem with this is that SelectHTMLAttributes already has an onChange property with a different signature, which accepts an event instead of a string

[federico-ntr]

Actually, it has also a handleChange, I found a way to override it but it's not really elegant.

[federico-ntr]

I implemented the aforementioned way to override the signature (using Omit<K,V>) but feel free to to suggest better alternatives

[dej611]

I think it is not a good idea to have a default id value, as id is something that should be unique in a DOM tree.
If the only reason to have it is to use it as reference for the label tag, I could suggest branching the rendering based on the id value:

• if none is passed, then the label tag will wrap the Input component
• otherwise use the current structure (without the -select suffix)

[federico-ntr]

I agree with you, my bad for not knowing label could wrap its component

[dej611]

Also, need to add a note on the Changelog page about the component change and breaking changes.
Possibly a guide on how to migrate from the Select 4.x to the Select 5.x would be nice, but not mandatory.

[federico-ntr]

Also, need to add a note on the Changelog page about the component change and breaking changes. Possibly a guide on how to migrate from the Select 4.x to the Select 5.x would be nice, but not mandatory.

I think this belongs to another PR, since nobody has started writing it yet, not even for already implemented features.

[sabato-galasso]

It is okay for me