Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hero component #1104

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix: hero component #1104

merged 5 commits into from
Oct 15, 2024

Conversation

Virtute90
Copy link
Contributor

@Virtute90 Virtute90 commented Sep 12, 2024

Fixes #1092

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Corrette le problematiche della issue inoltre spostato componente nello storybook da "Menù di navigazione" a "Componenti".
Corretta documentazione.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Sep 16, 2024 5:46pm

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (548608a) to head (a21aa27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1104   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         357      357           
  Lines       25230    25230           
  Branches     1688     1688           
=======================================
  Hits        24560    24560           
  Misses        668      668           
  Partials        2        2           
Flag Coverage Δ
unittests 97.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit 4d17fe7 into italia:main Oct 15, 2024
5 checks passed
@Fupete
Copy link

Fupete commented Oct 15, 2024

@astagi @Virtute90 vi segnalo che nella preview su Vercel è saltato il font Titillium Web nei componenti. Va bene?

@Virtute90 Virtute90 deleted the fix/hero branch October 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Componente hero: review a11y
3 participants