Added dependencies to compile cie_sign_sdk #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please no. This is exactly what one should not do on linux. A user should either install these from its distribution or download the sources from the project repositories. If you include the sources, then they get stuck at a given and do not receive any security change; furthermore, you are not able to follow small upstream changes, that will accumulate; after a while bumping to the new library version will be a real, huge pain, and you'll have to rewrite everything. Not to mention that by freezing the libraries you don't get security updates, and this is perhaps the last thing you should do with a sensitive piece of code like this. |
|
100% agree with @mmorandi |
|
@AntonioCiccarelli can you please check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.