Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale #77

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update stale #77

wants to merge 7 commits into from

Conversation

charlesRmajor
Copy link
Contributor

Update "update" function to match Apple's updated method, including supporting staleIn time same as in createActivity.

The previous method has been deprecated

NOTE: this new "update" function requires iOS version 16.2, not 16.1. I replaced all of the 16.1's with 16.2, but I don't know if that's what you'll want for the package. My need definitely doesn't cover supporting users who insist on being on 16.1.

(Thanks for making this easy for us, Apple, lol)

Copy link
Owner

@istornz istornz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please look at my two little comments/suggestions? 🥇

lib/live_activities.dart Outdated Show resolved Hide resolved
lib/live_activities.dart Outdated Show resolved Hide resolved
@istornz
Copy link
Owner

istornz commented Apr 4, 2024

@charlesRmajor Sorry for the delay, I was in vacation :/

It's good for me, can you fix conflicts before merging?

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants