Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respond with content-type octet-stream #34

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Respond with content-type octet-stream #34

merged 3 commits into from
Jan 23, 2024
+5 −2

Conversation

AndreasDahl
Copy link
Contributor

We need to set the content-type head to octet-stream to interact properly with thin-layer

@AndreasDahl AndreasDahl requested a review from a team as a code owner January 23, 2024 09:25
Victor-N-Suadicani
Victor-N-Suadicani suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Victor-N-Suadicani Victor-N-Suadicani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to increment the kanin version (a patch version is enough in this case).

kanin/src/app/task.rs Outdated Show resolved Hide resolved
@AndreasDahl AndreasDahl merged commit 0bc3cf2 into main Jan 23, 2024
4 checks passed
@AndreasDahl AndreasDahl deleted the respond-with-content-type-octet-stream branch January 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-N-Suadicani Victor-N-Suadicani Victor-N-Suadicani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasDahl @Victor-N-Suadicani