autoOne functionality update for Agda v2.7.0 and up #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change agsy to mimer
Add rw_complete
|
Looks very reasonable, thanks! Let's see what CI says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 2.7.0 of Agda and the introduction of mimer (instead of agsy) for auto mode, Cmd_autoOne comes with arguments:
(see https://github.com/agda/agda/blob/11e54c0e0229996c22ed7b53a50694933de84b09/src/full/Agda/Interaction/Base.hs#L174 for reference). This is an inconsitency between agda and cornelis types for interaction and brakes cornelis command :CornelisAuto which throws an error.
The proposed change to the repository fixes the issue and creates type consistency between cornelis and agda Interaction datatype.