Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added html attribute autocomplete #40

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

Dosan015
Copy link
Contributor

@Dosan015 Dosan015 commented Jan 4, 2024

No description provided.

@isosphere
Copy link
Owner

It is my understanding that the autocomplete attribute has a finite number of potential values:

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

To that end, I think we should go farther in our support for it by implementing an enum that encompasses all of them. This will improve the ergonomics for our end users, by saving them from having to consult additional documentation and instead just examine the enum options.

@isosphere isosphere merged commit 1d80ba9 into isosphere:main Jan 5, 2024
1 check passed
@isosphere
Copy link
Owner

isosphere commented Jan 5, 2024

Thank you for your contribution, and for implementing deeper support!

This is published in version 0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants