-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v0.82.0 #1845
Merged
Merged
release v0.82.0 #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem currently we only have designs for broken links and not duplicate permalinks. add a less confusing state when the site only has duplicate permalinks. note that design is currently working on the iterations for duplicate permalinks, this is just a temp measure ## Before & After Screenshots **BEFORE**: ![Screenshot 2024-03-12 at 8.49.44 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/62564a76-7e5c-452a-8c5d-ecb7e7a28a56.png) <!-- [insert screenshot here] --> **AFTER**: ![Screenshot 2024-03-12 at 8.54.11 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/f2af7d8b-023a-46af-8261-2245e0e301d1.png) <!-- [insert screenshot here] -->
* fix(sl constants): ensure route is intercepted * feat(sl): add mocks for sl * feat(sl): checklist copy changes + copied tooltip * feat(sl): change API so that step no. can increase * feat(sl): add storybooks * fix(cl): fix visual bug for no of tasks * fix(sl checklist): fix colors
## Problem This PR attempts to fix the functional issues wrt to Accordions. Will leave paddings as separate since those will be easier to fix + don't really need much context to be worked on. Fix bunch of stuff [here](https://www.notion.so/opengov/Accordion-1de9bd79bfa540daacfdc5b703a80b00?pvs=4) To test template stuff, need to make changes to [kishore-test](https://staging-cms.isomer.gov.sg/sites/kishore-test/editPage/accordion%20page.md) Corresponding template pr: isomerpages/isomerpages-template#361 (doesnt block this pr since complex blocks are behind feature flag anyway) deprior padding related fix as design is not 100% sure about it yet + padding are easier to fix so no biggie ![Screenshot 2023-12-06 at 4 15 20 PM](https://github.com/isomerpages/isomercms-frontend/assets/42832651/e3bbcc01-4c48-4043-a05d-23b945e990d5) ## Reviewer notes The approach for this PR would look weird considering the buttons are not bubble-menued. I did try it but it kept popping up on every individual cell (similar behaviour to our table stuff). I somehow couldnt get it to work since (note that there were 2 levels of abstraction here [bubbleMenu in react/src](https://github.com/ueberdosis/tiptap/blob/main/packages/react/src/BubbleMenu.tsx) -> [bubblemenu in the extensions](https://github.com/ueberdosis/tiptap/blob/main/packages/extension-bubble-menu/src/bubble-menu.ts)). As of now, the API is not extensible enough to allow for this to happen, and this wasnt just a trivial as a `.extend` that we do for our other extensions like `table` .There might be a way, please let me know if that is the case, but i time boxed this effort and just wrapped it around `NodeViewWrapper` to at least land something in main line first. This is still feature flagged and thus safe to merge to production for now, but hopefully p1 issues are all fixed and the pending stuff are just padding css stuff
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.3 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3) Updates `@cypress/request` from 2.88.11 to 2.88.12 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.11...v2.88.12) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: "@cypress/request" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.7 to 3.0.6. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.4.7...3.0.6) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [msw](https://github.com/mswjs/msw) from 0.42.3 to 1.3.2. - [Release notes](https://github.com/mswjs/msw/releases) - [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md) - [Commits](mswjs/msw@v0.42.3...v1.3.2) --- updated-dependencies: - dependency-name: msw dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 Co-authored-by: snyk-bot <[email protected]>
Snyk has created this PR to upgrade @tiptap/extension-highlight from 2.1.12 to 2.1.16. See this package in npm: https://www.npmjs.com/package/@tiptap/extension-highlight See this project in Snyk: https://app.snyk.io/org/isomer/project/6c92f53d-573a-40d5-aec0-9ee432ca5a7d?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-POSTCSS-5926692 Co-authored-by: snyk-bot <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Merged
alexanderleegs
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
#1840
#1816
#1808
#1806
#1828
#1730
#1653
#1440
#1832
#1831
#1830
Dependencies
#1538
#1441
Dev-Dependencies
#1599
#1550
Tests
deps: fix package-lock.json
#1840
npm run tests
)!run e2e
)Feat/fixSLStyling
#1440
None, mostly to sped up reviewal + trivial copy changes
Full Changelog: https://github.com/isomerpages/isomercms-frontend/compare/v0.81.0..v0.82.0