Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.82.0 #1845

Merged
merged 16 commits into from
Mar 14, 2024
Merged

release v0.82.0 #1845

merged 16 commits into from
Mar 14, 2024

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Mar 14, 2024

New

  • deps: fix package-lock.json #1840
  • fix: package.json to reduce vulnerabilities #1816
  • fix: upgrade @tiptap/extension-highlight from 2.1.12 to 2.1.16 #1808
  • fix: package.json to reduce vulnerabilities #1806
  • fix(path-traversal): add regex to prevent path traversal attack #1828
  • fix p1 accordion issues #1730
  • fix(hero): add background color #1653
  • Feat/fixSLStyling #1440
  • feat(app): add link between traces + rum #1832
  • fix(no broken link): not reporting duplicate permalink #1831
  • 0.81.0 #1830

Dependencies

  • chore(deps): bump dompurify from 2.4.7 to 3.0.6 #1538
  • chore(deps): bump tough-cookie and @cypress/request #1441

Dev-Dependencies

  • chore(deps-dev): bump @babel/traverse from 7.22.8 to 7.23.2 #1599
  • chore(deps-dev): bump msw from 0.42.3 to 1.3.2 #1550

Tests

deps: fix package-lock.json #1840

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

Feat/fixSLStyling #1440

None, mostly to sped up reviewal + trivial copy changes

Full Changelog: https://github.com/isomerpages/isomercms-frontend/compare/v0.81.0..v0.82.0

dcshzj and others added 16 commits March 11, 2024 19:23
## Problem

currently we only have designs for broken links and not duplicate permalinks. 
add a less confusing state when the site only has duplicate permalinks. note that design is currently working on the iterations for duplicate permalinks, this is just a temp measure


## Before & After Screenshots

**BEFORE**:

![Screenshot 2024-03-12 at 8.49.44 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/62564a76-7e5c-452a-8c5d-ecb7e7a28a56.png)

<!-- [insert screenshot here] -->

**AFTER**:

![Screenshot 2024-03-12 at 8.54.11 AM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/f2af7d8b-023a-46af-8261-2245e0e301d1.png)

<!-- [insert screenshot here] -->
* fix(sl constants): ensure route is intercepted

* feat(sl): add mocks for sl

* feat(sl): checklist copy changes + copied tooltip

* feat(sl): change API so that step no. can increase

* feat(sl): add storybooks

* fix(cl): fix visual bug for no of tasks

* fix(sl checklist): fix colors
## Problem

This PR attempts to fix the functional issues wrt to Accordions. 
Will leave paddings as separate since those will be easier to fix + don't really need much context to be worked on. 

Fix bunch of stuff [here](https://www.notion.so/opengov/Accordion-1de9bd79bfa540daacfdc5b703a80b00?pvs=4)

To test template stuff, need to make changes to [kishore-test](https://staging-cms.isomer.gov.sg/sites/kishore-test/editPage/accordion%20page.md)

Corresponding template pr: isomerpages/isomerpages-template#361 (doesnt block this pr since complex blocks are behind feature flag anyway)

deprior padding related fix as design is not 100% sure about it yet + padding are easier to fix so no biggie

![Screenshot 2023-12-06 at 4 15 20 PM](https://github.com/isomerpages/isomercms-frontend/assets/42832651/e3bbcc01-4c48-4043-a05d-23b945e990d5)


## Reviewer notes

The approach for this PR would look weird considering the buttons are not bubble-menued. 
I did try it but it kept popping up on every individual cell (similar behaviour to our table stuff). I somehow couldnt get it to work since (note that there were 2 levels of abstraction here [bubbleMenu in react/src](https://github.com/ueberdosis/tiptap/blob/main/packages/react/src/BubbleMenu.tsx) -> [bubblemenu in the extensions](https://github.com/ueberdosis/tiptap/blob/main/packages/extension-bubble-menu/src/bubble-menu.ts)). As of now, the API is not extensible enough to allow for this to happen, and this wasnt just a trivial as a `.extend` that we do for our other extensions like `table` .There might be a way, please let me know if that is the case, but i time boxed this effort and just wrapped it around `NodeViewWrapper` to at least land something in main line first. 

This is still feature flagged and thus safe to merge to production for now, but hopefully p1 issues are all fixed and the pending stuff are just padding css stuff
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together.

Updates `tough-cookie` from 2.5.0 to 4.1.3
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3)

Updates `@cypress/request` from 2.88.11 to 2.88.12
- [Release notes](https://github.com/cypress-io/request/releases)
- [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md)
- [Commits](cypress-io/request@v2.88.11...v2.88.12)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: "@cypress/request"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.7 to 3.0.6.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.4.7...3.0.6)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [msw](https://github.com/mswjs/msw) from 0.42.3 to 1.3.2.
- [Release notes](https://github.com/mswjs/msw/releases)
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md)
- [Commits](mswjs/msw@v0.42.3...v1.3.2)

---
updated-dependencies:
- dependency-name: msw
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116

Co-authored-by: snyk-bot <[email protected]>
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-POSTCSS-5926692

Co-authored-by: snyk-bot <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dcshzj dcshzj merged commit de4d7b9 into master Mar 14, 2024
31 of 35 checks passed
@mergify mergify bot deleted the release_v0.82.0 branch March 14, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants