Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permalinks): default permalink for create #1843

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(permalinks): default permalink for create #1843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 46 additions & 6 deletions src/components/PageSettingsModal/PageSettingsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const PageSettingsModal = ({
}: PageSettingsModalParams) => {
const { siteName, fileName } = params
const isTiptapEnabled = useFeatureIsOn("is-tiptap-enabled")
const isPageCreated = !fileName

const existingTitlesArray = pagesData
.filter((page) => page.name !== fileName)
Expand Down Expand Up @@ -146,6 +147,23 @@ export const PageSettingsModal = ({
})
}

const getDefaultPermalink = (title: string) => {
if (!title) return ""
const titleSlug = title
.toLowerCase()
.replace(/[^a-z0-9]+/g, "-")
seaerchin marked this conversation as resolved.
Show resolved Hide resolved
.replace(/^-+|-+$/g, "")
seaerchin marked this conversation as resolved.
Show resolved Hide resolved
return `/${titleSlug}/`
}

const currTitle = watch("title")
const currPermalink = watch("permalink")
useEffect(() => {
if (isPageCreated && currPermalink !== getDefaultPermalink(currTitle)) {
setValue("permalink", getDefaultPermalink(currTitle))
}
}, [isPageCreated, setValue, currTitle, currPermalink])

return (
<Modal isOpen onClose={onClose}>
<ModalOverlay />
Expand All @@ -169,32 +187,54 @@ export const PageSettingsModal = ({
isLink={false}
/>
{/* Title */}
<FormControl isRequired isInvalid={!!errors.title?.message}>
<FormLabel>Page title</FormLabel>
<FormControl
isRequired
isInvalid={!!errors.title?.message}
mb="1rem"
>
<Box mb="0.75rem">
<FormLabel mb={0}>Page title</FormLabel>
<FormLabel.Description color="text.description">
This appears on the top of the browser window or tab
</FormLabel.Description>
</Box>
<Input
placeholder="Page title"
id="title"
{...register("title", { required: true })}
/>
<FormErrorMessage>{errors.title?.message}</FormErrorMessage>
</FormControl>
<br />
{/* Permalink */}
<FormControl isInvalid={!!errors.permalink?.message} isRequired>
<FormControl
isInvalid={!!errors.permalink?.message}
isRequired
mb="1rem"
>
<Box mb="0.75rem">
<FormLabel mb={0}>Page URL</FormLabel>
<FormLabel.Description color="text.description">
{`${siteUrl}${watch("permalink")}`}
{isPageCreated
? "You can change this later in Page Settings."
: `${siteUrl}${watch("permalink")}`}
</FormLabel.Description>
</Box>
<Input
{...register("permalink", { required: true })}
id="permalink"
placeholder="Insert /page-url or https://"
isDisabled={isPageCreated}
/>
{isPageCreated && (
<Box my="0.5rem">
<Text textStyle="body-2">
{`${siteUrl}${watch("permalink")}`}
</Text>
</Box>
)}

<FormErrorMessage>{errors.permalink?.message}</FormErrorMessage>
</FormControl>
<br />
{isTiptapEnabled && (
<FormControl isInvalid={!!errors.permalink?.message} isRequired>
<Flex mb="0.75rem" alignItems="center">
Expand Down
Loading