Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.77.0 #1812

Merged
merged 1 commit into from
Feb 22, 2024
Merged

0.77.0 #1812

merged 1 commit into from
Feb 22, 2024

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Feb 22, 2024

What's Changed

Full Changelog: v0.76.0...v0.77.0

Tests

  • put in the following content into the markdown files
Allowed script 

<script src="//www.instagram.com/embed.js" async="true"></script>

Disallowed in csp

<script src="//www.evil.com/embed.js" async="true"></script>

Allowed in csp but should also be controlled

<script src="//www.blah.cloudfront.net/embed.js" async="true"></script>


Attributes not allowed 

<svg><script src="/jquery/jquery.min.js" href="THISFILEWILLBELOADED"></script></svg>
<svg><script src="/jquery/jquery.min.js" xlink:href="THISFILEWILLBELOADED"></script></svg>

  • press save

  • accept the disclaimer if it pops up

  • post save, only one of the 3 script tags should persist

  • Log in to staging via github

  • Access the page /sites//linkCheckerReport for any site here

  • Verify that the content is loading, and you are able to access the page in staging + you are able to go into a valid edit page

  • Verify that when you click on the breadcrumbs on the side, it leads to the correct table (ie what was done in the video above)

  • When accessing /sites/<your-site-name>/linkCheckerReport on staging, it should result in a redirect back to the dashboard.
    IMPORTANT so as to not trip off alarms

  • When feature flag is off, no network calls should be made to getLinkCheckerStatus in the backend

@alexanderleegs alexanderleegs merged commit cd8eff0 into develop Feb 22, 2024
31 of 35 checks passed
@mergify mergify bot deleted the release/0.77.0 branch February 22, 2024 10:25
@kishore03109 kishore03109 mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants