Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.64.0 #1740

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Release/0.64.0 #1740

merged 9 commits into from
Dec 12, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Dec 12, 2023 •
edited
Loading

What's Changed

New Contributors

Full Changelog: v0.63.2...v0.64.0

seaerchin and others added 7 commits December 6, 2023 13:39
@seaerchin
Merge pull request #1725 from isomerpages/release/v0.63.0
070c200 
release(0.63.0): merge to develop
@seaerchin
Merge pull request #1732 from isomerpages/hotfix/v0.63.1
810bcaa 
hotfix/v0.63.1
@seaerchin
Merge pull request #1734 from isomerpages/hotfix/v0.63.2
91a8de2 
Hotfix/v0.63.2
@dcshzj
chore(sidebar): update link to issue reporting form (#1737)
0a852a2
@QiluXie
IS-712 Fixed image resizing issue in RTE (#1736)
b1eb900 
* Fixed image resizing issue in RTE

* removed width attribute and used style tag to set the value of the form

* removed useless comments and added useful ones

* add 100% width as default to style tag for parity

* added command on image extension to set style and use it

* added explicit type for imageStyle for width and background color

* removed backcolor property
@seaerchin
refactor(legacy/markdown-editpae): update width (#1739)
64681c4
@QiluXie
IS-807 Fixed duplicating issue when setting hyperlink & alt text for …
c765bde 
…image in RTE (#1738)

* fixed duplicating issue of setImage method inside image exntension

* added setImageMeta to set image attribute

* restricted input type for setImageMeta
@dcshzj dcshzj requested a review from seaerchin December 12, 2023 09:44
@mergify Mergify
Copy link

mergify bot commented Dec 12, 2023

⚠️ The sha of the head commit of this PR conflicts with #1741. Mergify cannot evaluate rules on this PR. ⚠️

@dcshzj
Copy link
Contributor Author

dcshzj commented Dec 12, 2023 •
edited
Loading

#1737 - @seaerchin

  • Navigate to any site's workspace
  • Click on the "Help" button on the sidebar
  • Verify that the link is a valid Go.gov.sg link.

#1736 & #1738 - @dcshzj

  • Go to staging CMS and click the repo qilu-site-test
  • Go to rte test page
  • There are 3 existing images, try to modify the hyperlink and altText of them, notice that no duplicate image is created and the properties are modified successfully
  • Try to create a new image by clicking the icon in the toolbar
  • Observe the image creation is successful
  • Try to delete those images and observe the deletions are successful
  • Click on any of the image and resize
  • Observe that the image is resized on the preview

#1739 - @dcshzj

  • go to any site, and add some content
  • ensure that viewport is small (1024)
  • turn off the flag for staging (is-tiptap-enabled)
  • check that on legacy editpage (no banner saying to use new editor), the preview has space.
  • turn on the flag
  • check that on new editpage (has banner), the preview has space.

@mergify Mergify
Copy link

mergify bot commented Dec 12, 2023

⚠️ The sha of the head commit of this PR conflicts with #1741. Mergify cannot evaluate rules on this PR. ⚠️

@dcshzj dcshzj merged commit c687d5e into master Dec 12, 2023
23 of 27 checks passed
@mergify mergify bot deleted the release/0.64.0 branch December 12, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcshzj @seaerchin @QiluXie