release(v0.63.0): merge to production #1726
Conversation
0.62.0 to develop
* feat(tiptap): add card grid block * feat(cards): add basic bubble menu * feat(cards): adjust editor commands to support creation
* feat(tiptap): add card grid block * feat(cards): adjust editor commands to support creation * feat(cards): introduce drawer to support sub-editing
* feat(tiptap): allow inserting of complex blocks * feat(tiptap): add card grid block * feat(cards): add basic bubble menu * feat(cards): adjust editor commands to support creation * feat(cards): introduce drawer to support sub-editing * feat(cards): allow editing of cards within drawer * feat(cards): support undo/redo of cards editing * feat(cards): render preview the same way as template * fix(cards): update inputs when switching card positions * fix(cards): insert node instead of replace * fix(cards): force update display image checkbox * fix(cards): avoid using useEffect and use callback * fix(cards): add link validation and delete confirmation * styles(card): support hover for node view * fix(cards): trigger form validation and update preview * docs(cards): add info on how setCardsContent works * fix(cards): use Editor CSS module instead * styles(card): add bottom margin if not last item
* fix(editor): improve embed functionality * fix(embed): change placement of bubble menu
* feat: select modal revamp for existing functionality * feat: add tab for inserting external images * feat: add validation for external images * fix: maintain errors on blur * fix: selection of image after clicking into external tab * fix: ux issues * fix: rerendering issue * fix: change search to debounced real time * fix: styling issues * chore: searchbar copy * chore: remove search in all button * fix: drop onExternalProceed for mediaModal * chore: shift folderBreadcrumb and debounce time * chore: remove unnecessary conditional * fix: remove unused components * fix(mediasselectmodal): add 1px top padding --------- Co-authored-by: seaerchin <[email protected]>
## Problem Basic Accordion Block  ## New env var TIPTAP_PRO_TOKEN: needed to get the private npm package During deployment, please update Netlify NOT DONE: Differing background colour Conversion from Old Accordion code to the newer format Checking in with design on hover for the plus button in the editor Checking in with Design on the margins for accordion
## Problem Add background colours Note: quite a bit of code was taken from @dcshzj's PR here #1705. (ps still learning how use graphite, will attempt to cherry pick in the future) The toggle is still a bit flaky, will be documenting in a notion doc <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/4JosFH65rhzwIvkZw2J6/33ec7c00-6253-4ff9-b1a8-abc1cc25dcab.mov"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/4JosFH65rhzwIvkZw2J6/33ec7c00-6253-4ff9-b1a8-abc1cc25dcab.mov"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/4JosFH65rhzwIvkZw2J6/33ec7c00-6253-4ff9-b1a8-abc1cc25dcab.mov">Screen Recording 2023-11-28 at 4.47.19 PM.mov</video>
* fix(markdowneditpage): fix styling on big screens (1920+) * fix(blockwrapper): update outline to border to prevent bottom border disappearing on drag * refactor(editpage): shift out editor call * feat(imageview): add wrapper for image view * feat(iframeview): add wrapper * refactor(views): add blockwrapper to embeds * fix(usetiptapeditor): add trailing ode * refactor(views): update formsg/instagram to show embed only
## Problem The old embed view is very different from how the rest of our editor looks like due to it not using our theme colours/styling. ## Solution Change the design to a design approved design! ## Screenshots <img width="599" alt="Screenshot 2023-12-05 at 3 09 54 PM" src="https://github.com/isomerpages/isomercms-frontend/assets/44049504/9792b585-1d18-4d0b-a7a6-6ffcf3d6c0ce">
* feat(table): add initial table view * refactor(blockwrapper): add new draghandle * fix(editor/table): update stylings
* feat(editor): feature flag complex blocks * chore: fix typo * fix(editor): simplify isHidden prop
|
|
|
wtf alot of changes sia |
|
@seaerchin #1697 - ignoring, cannot see cards accordion
|
|
@kishore03109 #1719 (adding rn monkas) [done] @kishore03109 #1718 (adding rn monkas) |
|
Current issues Backspace on table + embed gives weird output Adding image to a newly created page throws an error Embed currently doesnt have the bubble menu to change link/ unable to change link on click. (not sure if this was deprioritised) |
* fix(blockwrapper): remove padding oops * fix(styles): update to onlyk shiow placeholder for first empty p * fix(image): update insertion logic * fix(formsg): remove formsg ext to use default iframe; fix regex for embeds
|
@kishore03109 thanks for catching the embed issues are specifically formsg embeds specific because we (in the form of tiptap extensions) differentiate between iframe/insta/formsg embeds. i tested w/ all 3 for the backspace + the embed menu -> no issue the insert image one is fixed with slightly wonk semantics, as follows:
Videovideo of new behaviour for formsg embed (technically this is just a normal embed to tiptap now) -> we strip the div as there's no extension supported -> we still retain the text content of the div (the behaviour is we still parse the child -> tiptap understands raw text + a tags so this is retained) but div itself is removed. For formsg, the Screen.Recording.2023-12-06.at.11.47.57.AM.mov |
seaerchin
force-pushed
the
release/v0.63.0
branch
from
c687f3d to
b38ff5b
Compare
seaerchin
force-pushed
the
release/v0.63.0
branch
from
b38ff5b to
5b03571
Compare
|
|
What's Changed
Full Changelog: v0.62.0...v0.63.0