Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/0.58.0 #1676

Merged
merged 14 commits into from
Nov 14, 2023
Merged

release/0.58.0 #1676

merged 14 commits into from
Nov 14, 2023

Conversation

harishv7
Copy link
Contributor

Duplicate of #1675

kishore03109 and others added 14 commits November 9, 2023 17:36
@kishore03109
Merge pull request #1661 from isomerpages/release/0.57.0
4576754 
0.57.0
@seaerchin
refactor(tiptap-editor): update width (#1667)
df2af8f
@seaerchin
refactor(editpage): add alt text modal (#1665)
b9e2991
@dcshzj
chore(login): automatically focus on input field (#1664)
fbe4d68
@seaerchin
fix(editor): change inner prosemirror stuff to have 100% height (#1670)
f710706
@kishore03109
fix(image): search pagination (#1668)
7b25cfb
@alexanderleegs
chore: update select media modal (#1627)
ff2e005 
* chore: update select media modal

* fix: style changes

* chore: upgrade design system
@dcshzj
fix(preview): use site colours for headings in preview (#1663)
83a1adc 
* fix(preview): use site colours for headings in preview

* fix(preview): use secondary colours for quotes as well
@kishore03109
Fix/buildStatusBadgeAPI (#1673)
b0a1e98 
* fix(statusBadge): rm lingering api call

* fix(stagingStatus): rm unused imports

* fix(status Badge): fix storybook not rendering

* fix(badgeStatus): add in qnmark

* fix(badgeStatus): fix styling issues
@dcshzj
feat(media): allow create album with selected media (#1666)
ab12c0c 
* chore(media): move utility method outside

* feat(hooks): add new hook to create and move together

* feat(media): add new create media folder modal

* feat(media): add new modal to Media layout

* styles(media): adjustments from design feedback

* feat(media): add pagination support for modal

* fix(media): add methods as dependency of useEffect

* fix(media): standardise to use onTouched for validation

* fix(media): adapt strings to mediatype and plurals

* fix(media): omit selected pages when skipping selection

* fix(media): avoid prop drilling siteName and isWriteDisabled

* style(media): add padding to allow outline to show
@dcshzj
feat(media): add announcements and feature tour for media enhancements (
d694c19 
#1632)

* feat(media): add announcements and feature tour for media enhancements

* feat(media): add announcement image

* chore(media): adjust to use feature tour target IDs directly

* fix(assets): fix exports of images
@kishore03109
feat/addReportingBUtton (#1674)
44ea8f8
@seaerchin
fix(markdown): update styling to remove overflow (#1671)
e141830 
* fix(template): u9pdate styling for editor

* refactor(editor): update styling to own file
@harishv7
0.58.0
990ceb4
@mergify Mergify
Copy link

mergify bot commented Nov 14, 2023

⚠️ The sha of the head commit of this PR conflicts with #1675. Mergify cannot evaluate rules on this PR. ⚠️

@cypress Cypress
Copy link

cypress bot commented Nov 14, 2023 •
edited
Loading

51 failed tests on run #433 ↗︎

51 47 1 32 Flakiness 0

Details:

release/0.58.0
Project: isomercms-frontend Commit: 990ceb4de7
Status: Failed Duration: 25:03 💡
Started: Nov 14, 2023 8:57 AM Ended: Nov 14, 2023 9:22 AM
Failed  editPage.spec.ts • 11 failed tests

View
Output
Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should provide a warning to users when navigating away Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to modify and save content Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new image Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to upload and add new file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing file Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add link Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should have correct colour Screenshots Video
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  files.spec.ts • 10 failed tests

View
Output
Video

Test Artifacts
Files > Create file, delete file, edit file settings in Files > Files should contain Directories and Ungrouped Files Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to create new file with valid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to delete file Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to create new file directory Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory Screenshots Video
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to add file to file directory Screenshots Video
Failed  folders.spec.ts • 10 failed tests

View
Output
Video

Test Artifacts
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to rename a sub-folder Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder with a page Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder without page Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to create a new page with valid title and permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid title Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Chinese title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to delete existing page in folder Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to create a new page with valid title and permalink Screenshots Video
Failed  homepage.spec.ts • 6 failed tests

View
Output
Video

Test Artifacts
Homepage > Block editing > should display the site notification correctly Screenshots Video
Homepage > Block editing > should only allow up to 4 highlights for the hero section Screenshots Video
Homepage > Block editing > should remove the button in preview when the hero button content is not given Screenshots Video
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section Screenshots Video
Homepage > Block editing > should limit users to a single resource component Screenshots Video
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order Screenshots Video
Failed  images.spec.ts • 1 failed test

View
Output
Video

Test Artifacts
Images > Create album, delete album, edit album settings in Images > Should be able to create new album Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Review all test suite changes for PR #1676 ↗︎

@alexanderleegs alexanderleegs merged commit 9d3fa88 into master Nov 14, 2023
31 of 35 checks passed
@mergify mergify bot deleted the release/0.58.0 branch November 14, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harishv7 @alexanderleegs @kishore03109 @seaerchin @dcshzj