Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.57.0 #1660

Merged
merged 7 commits into from
Nov 9, 2023
Merged

0.57.0 #1660

merged 7 commits into from
Nov 9, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 9, 2023 •
edited
Loading

v0.57.0

  • fix(menubar): remove uuid #1659
  • fix(badge): flickering issue #1657
  • feat(images): bulk upload #1654
  • feat(media): introduce new move media modal #1652
  • IS-685 enhance delete images #1631
  • release(0.56.0): merge to dev #1649

seaerchin and others added 7 commits November 3, 2023 17:39
@seaerchin
Merge pull request #1649 from isomerpages/release/v0.56.0
71f382e 
release(0.56.0): merge to dev
@harishv7
IS-685 enhance delete images (#1631)
f5387ec 
* feat: copy changes

* feat: add checkbox confirmation

* feat: enhance modal for folder deletion

* remove console log
@dcshzj
feat(media): introduce new move media modal (#1652)
bcb1479 
* fix(delete): reset delete check on modal closure

* feat(breadcrumbs): generalise media breadcrumbs

* chore(assets): add new BxErrorSolid icon

* feat(media): introduce new move media modal

* feat(media): add new move multiple media hook

* feat(media): update media page to support new move modal

* style(media): update styling based on design feedback

* style(media): place image name inside modal title

* fix(media): update object structure to match backend requirements

* chore(media): remove old media move modal

* style(media): truncate if directory name is too long

* style(media): update media layout styles based on design feedback

* fix(media): abstract path handling to utility functions and add comment
@seaerchin
feat(images): bulk upload (#1654)
278e210 
* feat(mediafileservice): add new endpoint for creating single file

* refactor(attachment): add new section for errrors

* refactor(attachmentdropzone): add button link

* feat(media): add new types

* feat(hooks): add new hook to create multiple media

* feat(media-creation-components): add new components for modal

* refactor(mediacreationmodal): add new flow for bulk creation

* feat(mediacreationmodal): add prog bar

* refactor(attachment): remove max # of uploads

* refactor(creation-modal): update copyu

* refactor(attachment): remove extra text

* refactor(creation-modal): add on more when reupload

* refactor(attachment): update copy

* refactor(attachment-file-info): update styling to avoid overflow into multiple lines

* fix(attachmenterror): update styling to prevent text overflow

* refactor(attachmenterror): update styling

* refactor(attachment): update divider logic

* refactor(mediacreationmodal): inline error list

* refactor(mediacreationmodal): remove import

* refactor(media-ceration): change dropzone to update accept dynamically

* refactor(media-creation): update naming

* fix(attachment): update overflow behaviour

* refactor(mediacreaitonmodal): update naming

* fix(mediacreationmodal): update types
@kishore03109
fix(badge): flickering issue (#1657)
2eeef22 
* fix(badge): flickering issue

* fix(badge): hover

* fix(statusBadge): wrong colours

* chore(stausBadge): rm redundant use memo
@seaerchin
fix(menubar): remove uuid (#1659)
478e19e
@kishore03109
0.57.0
14678e1
@mergify mergify bot mentioned this pull request Nov 9, 2023
Merged
@kishore03109
Copy link
Contributor Author

kishore03109 commented Nov 9, 2023 •
edited
Loading

#1652

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

Smoke test steps:

  • Navigate to any site and access the Images workspace
  • Select a single image in the root folder, click on the "Edit selected" menu on the top right and click "Move images to album"
  • Verify that the modal shown loads the images directory and its contents correctly
  • Move the image to another album
  • Verify that the image is correctly moved to the above album
  • Select multiple images in any of the albums (have a mixture of images from different albums), click on the "Edit selected" menu on the top right and click "Move images to album"
  • Move the images to another album
  • Verify that the images are correctly moved to the above album
  • Navigate to the Files workspace
  • Click on the kebob menu and select "Move to"
  • Move the file to another directory
  • Verify that the file is correctly moved to the above directory

manually verified by @kishore03109

@kishore03109
Copy link
Contributor Author

kishore03109 commented Nov 9, 2023 •
edited by seaerchin
Loading

#1631

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests
    • Refer to above AFTER screenshots. Visit the respective pages - Workspace, resource room, files, images and ensure that both deleting of a single resource (e.g. a file) or an directory (e.g. an album) pops up the above modal

manually verified by @kishore03109

@seaerchin
Copy link
Contributor

seaerchin commented Nov 9, 2023 •
edited
Loading

#1654

Tests

  • go to staging and click on a site
  • go to images
    below steps are via clicking - take note that clicking should not allow other formats
  • upload a single image
  • it should work
  • upload a image with spaces and other disallowed characters
  • it should owrk, image should have disallowed chars renamed to _
  • upload an existing image
  • it should fail and display an error message
  • upload many (>1) image by clicking and triggering the modal
  • it shuold work
  • click and select 1 image
  • click and select another image (don't close modal yet)
  • this should allow two images to be uploaded
  • this should work
    repeat the above steps for dragging - should allow other formats, but will have error message

repeat for files - should only allow pdf

@kishore03109 kishore03109 merged commit f218f9b into master Nov 9, 2023
31 of 35 checks passed
@mergify mergify bot deleted the release/0.57.0 branch November 9, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kishore03109 @seaerchin @harishv7 @dcshzj